Does whitening help with all types of discoloration?

No. Surface stains usually respond better to whitening than deep intrinsic discoloration.